Open
Conversation
# Conflicts: # RFC-by-stage/1-approved/separate-components.md
elisechant
changed the title
Contributor
|
Shall we roll this in to #2 ? |
elisechant
reviewed
Dec 14, 2021
| ```sh | ||
| . | ||
| └── packages | ||
| ├── react |
Contributor
There was a problem hiding this comment.
rather than packages/buttons/react ? in your example, are you proposing new npm names?
Member
Author
There was a problem hiding this comment.
I'm not set on the naming. I proposed this structure because it would make dependency management across the same architecture easier. I would assume with what I propose you would only ever use the react entry point for npm which would remain unchanged. Vanilla or jquery does not use need npm packages and does not have them now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple RFC but it will require a bunch of work that can be separated from the other work.
Good to keep things separated so we can move in smaller chunks